remove it from the trait menu pending discussion;

if this is to make it into a generic trait; it would need to be limited in instrument choice entirely.

Generic Trait = Only whatever instrument the Microphone is
Harpy = All instruments

remove it from the trait menu

why so?

remove it from the trait menu

why so?

i updated the comment, should make more sense

Generic Trait = Only whatever instrument the Microphone is Harpy = All instruments

It only gives microphone and some second instrument I forgot

Making the component generic is good; I have no idea how MIDI works but there should be some way to assign instruments per component. Ideally, the singer system is just the microphone instrument and then you can reuse it and add more instruments for Harpy

Making the component generic is good; I have no idea how MIDI works but there should be some way to assign instruments per component. Ideally, the singer system is just the microphone instrument and then you can reuse it and add more instruments for Harpy

:O

Fuck, uh... Turns out prototypedata class is apart of robust toolbox, I edited it locally, but the change wasn't committed... which is now a test fail.

I need to find a way to fix that...

This works fine now. Singing types are now defined separately from the trait and can be re-used later, which makes things like singing parrots as easy to implement as adding type: Singer, proto: NormalSinging to them.

Also, the cost has been reduced to 1.

test fail valid

This pull request has conflicts, please resolve those before we can evaluate the pull request.

test fail still valid

I'll look into it, but later

It was a single-line fix